Skip to content

Get rid of deprecated new instance calls#435

Closed
FSchumacher wants to merge 52 commits intoapache:trunkfrom
FSchumacher:get-rid-of-deprecated-newInstance-calls
Closed

Get rid of deprecated new instance calls#435
FSchumacher wants to merge 52 commits intoapache:trunkfrom
FSchumacher:get-rid-of-deprecated-newInstance-calls

Conversation

@FSchumacher
Copy link
Contributor

@FSchumacher FSchumacher commented Nov 27, 2018

Description

This basically is an update to #431

Get rid of calls to Class#newInstance() by replacing them with Class#getDeclaredConstructor()#newInstance()

And while I edited the classes I cleaned them up a bit, when eclipse showed warnings. I think those snippets should be committed separately, but I left them in here, so that they can be discussed if necessary.

Motivation and Context

Java 9 deprecates Class#newInstance().

How Has This Been Tested?

Tests should run when github merges this for testing.

Screenshots (if appropriate):

Types of changes

  • cleanup

Checklist:

@FSchumacher
Use StringUtils.isNotBlank to make intent clearer
9dabe9a
@FSchumacher
Replace deprecated newInstance calls
5db20ea
@FSchumacher
Use log format string
9ea1b7b
@FSchumacher
Get rid of deprecated newInstance call
c21bbd2
@FSchumacher
Get rid of deprecated newInstance call
c4a32b8 
Clarify the thrown exceptions of the createThinkTime method, while we
are here
@FSchumacher
Get rid of deprecated newInstance call
90ac826
@FSchumacher
Get rid of deprecated newInstance call
dc04575
@FSchumacher
Use log format strings
99dfb49
@FSchumacher
Simplify code.
632a30f 
With the introduction of varargs this can be written simpler. We don't
have to construct arrays here anymore.
@FSchumacher
Use Java conventions for names of parameters
59646b4
@FSchumacher
Use StringUtils#isNotBlank to make intent clearer
100bf93
@FSchumacher
Get rid of deprecated newInstance call
08413fb
@FSchumacher
Extract code to create BackendListenerClient from a classname
f10891f
@FSchumacher
Extract code into private methods to make intent clearer
e4e23ed
@FSchumacher
Use StringUtils.isNotBlank to make intent of code clearer
78f0870
@FSchumacher
Get rid of deprecated newInstance call
2d41ba0
@FSchumacher
Get rid of deprecated newInstance calls
cc882df
@FSchumacher
Get rid of deprecated newInstance calls
3e7030d
@FSchumacher
Use log string formats
ee05360
@FSchumacher
Get rid of deprecated newInstance call
d78b7c4
@FSchumacher
Get rid of deprecated newInstance call
39b104c
@FSchumacher
Get rid of deprecated newInstance call
92530c4
@FSchumacher
Get rid of deprecated newInstance call
9f74643
@FSchumacher
Get rid of deprecated newInstance call
3c8b2da
@FSchumacher
Get rid of deprecated newInstance call
d117321
@FSchumacher
Use log format strings
27f114f
@FSchumacher
Get rid of deprecated newInstance call
d5c50fc
@FSchumacher
Get rid of deprecated newInstance call
b77206e
@FSchumacher
Get rid of deprecated newInstance call
af2aa52
@FSchumacher
Get rid of deprecated newInstance call
f6ffad9
asfgit pushed a commit that referenced this pull request Dec 2, 2018
@FSchumacher
With varargs there is no need for the arrays
dc18430 
Part of #435 and Bugzilla Id: 62972


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847986 13f79535-47bb-0310-9956-ffa450edef68
asfgit pushed a commit that referenced this pull request Dec 2, 2018
@FSchumacher
Simplify code that tries to find the correct constructor
dee641b 
Part of #435 and Bugzilla Id: 62972


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847987 13f79535-47bb-0310-9956-ffa450edef68
asfgit pushed a commit that referenced this pull request Dec 2, 2018
@FSchumacher
Replace calls to deprecated method Class#newInstance
faf53bb 
Part of #435 and Bugzilla Id: 62972


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847989 13f79535-47bb-0310-9956-ffa450edef68
asfgit pushed a commit that referenced this pull request Dec 2, 2018
@FSchumacher
Adapt test case to new method of constructing instances
7598524 
Part of #435 and Bugzilla Id: 62972


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847990 13f79535-47bb-0310-9956-ffa450edef68
@asfgit asfgit closed this in dcb7579 Dec 2, 2018
StorDm pushed a commit to etnetera/jmeter that referenced this pull request Jan 7, 2021
@FSchumacher
Use StringUtils.isNotBlank to make intent clearer
bdb3f8e 
Part of apache#435 and Bugzilla Id: 62972


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847959 13f79535-47bb-0310-9956-ffa450edef68

Former-commit-id: 0747ca7
StorDm pushed a commit to etnetera/jmeter that referenced this pull request Jan 7, 2021
@FSchumacher
Replace deprecated newInstance calls
75fc0f7 
Part of apache#435 and Bugzilla Id: 62972


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847960 13f79535-47bb-0310-9956-ffa450edef68

Former-commit-id: 5470c38
StorDm pushed a commit to etnetera/jmeter that referenced this pull request Jan 7, 2021
@FSchumacher
Use log format strings
234e37f 
Part of apache#435 and Bugzilla Id: 62972


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847961 13f79535-47bb-0310-9956-ffa450edef68

Former-commit-id: d08e486
StorDm pushed a commit to etnetera/jmeter that referenced this pull request Jan 7, 2021
@FSchumacher
Replace calls to deprecated Class#newInstance
bfa8608 
Part of apache#435 and Bugzilla Id: 62972


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847964 13f79535-47bb-0310-9956-ffa450edef68

Former-commit-id: 431108b
StorDm pushed a commit to etnetera/jmeter that referenced this pull request Jan 7, 2021
@FSchumacher
Use log format strings
94669b1 
Part of apache#435 and Bugzilla Id: 62972


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847965 13f79535-47bb-0310-9956-ffa450edef68

Former-commit-id: 4f844ea
StorDm pushed a commit to etnetera/jmeter that referenced this pull request Jan 7, 2021
@FSchumacher
Simplify code
881595e 
Newer java versions have changed the method signatures to varargs. Use those varargs.
Part of apache#435 and Bugzilla Id: 62972


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847966 13f79535-47bb-0310-9956-ffa450edef68

Former-commit-id: b1c9cf0
StorDm pushed a commit to etnetera/jmeter that referenced this pull request Jan 7, 2021
@FSchumacher
Use Java naming conventions for parameter names
b4613b2 
Part of apache#435 and Bugzilla Id: 62972


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847969 13f79535-47bb-0310-9956-ffa450edef68

Former-commit-id: 23d608a
StorDm pushed a commit to etnetera/jmeter that referenced this pull request Jan 7, 2021
@FSchumacher
Use StringUtils#isNotBlank to make intent clearer
572c96e 
Part of apache#435 and Bugzilla Id: 62972


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847972 13f79535-47bb-0310-9956-ffa450edef68

Former-commit-id: 232583a
StorDm pushed a commit to etnetera/jmeter that referenced this pull request Jan 7, 2021
@FSchumacher
Replace calls to deprecated Class#newInstance
23a3fc1 
Part of apache#435 and Bugzilla Id: 62972


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847973 13f79535-47bb-0310-9956-ffa450edef68

Former-commit-id: 8993041
StorDm pushed a commit to etnetera/jmeter that referenced this pull request Jan 7, 2021
@FSchumacher
Extract code to create BackendListenerClient from a classname
3ec98af 
Part of apache#435 and Bugzilla Id: 62972


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847974 13f79535-47bb-0310-9956-ffa450edef68

Former-commit-id: 1744f9b
StorDm pushed a commit to etnetera/jmeter that referenced this pull request Jan 7, 2021
@FSchumacher
Extract code into private methods to make intent clearer
c40df6c 
Part of apache#435 and Bugzilla Id: 62972


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847975 13f79535-47bb-0310-9956-ffa450edef68

Former-commit-id: 569c141
StorDm pushed a commit to etnetera/jmeter that referenced this pull request Jan 7, 2021
@FSchumacher
Use StringUtils.isNotBlank to make intent of code clearer
cdd976b 
Part of apache#435 and Bugzilla Id: 62972


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847976 13f79535-47bb-0310-9956-ffa450edef68

Former-commit-id: b5f7acb
StorDm pushed a commit to etnetera/jmeter that referenced this pull request Jan 7, 2021
@FSchumacher
Replace calls to deprecated Class#newInstance method
105db4c 
Part of apache#435 and Bugzilla Id: 62972


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847977 13f79535-47bb-0310-9956-ffa450edef68

Former-commit-id: cac54e6
StorDm pushed a commit to etnetera/jmeter that referenced this pull request Jan 7, 2021
@FSchumacher
Use log format strings
13d1dfe 
Part of apache#435 and Bugzilla Id: 62972


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847978 13f79535-47bb-0310-9956-ffa450edef68

Former-commit-id: cb56c49
StorDm pushed a commit to etnetera/jmeter that referenced this pull request Jan 7, 2021
@FSchumacher
Replace calls to deprecated Class#newInstance method
0a0ffff 
Part of apache#435 and Bugzilla Id: 62972


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847979 13f79535-47bb-0310-9956-ffa450edef68

Former-commit-id: 970babc
StorDm pushed a commit to etnetera/jmeter that referenced this pull request Jan 7, 2021
@FSchumacher
Use log format strings
53fbc75 
Part of apache#435 and Bugzilla Id: 62972


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847980 13f79535-47bb-0310-9956-ffa450edef68

Former-commit-id: 741468c
StorDm pushed a commit to etnetera/jmeter that referenced this pull request Jan 7, 2021
@FSchumacher
Replace calls to deprecated Class#newInstance method
21a37d8 
Part of apache#435 and Bugzilla Id: 62972


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847981 13f79535-47bb-0310-9956-ffa450edef68

Former-commit-id: 53eefd1
StorDm pushed a commit to etnetera/jmeter that referenced this pull request Jan 7, 2021
@FSchumacher
Replace calls to deprecated Class#newInstance method
4a1e0bf 
Part of apache#435 and Bugzilla Id: 62972


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847982 13f79535-47bb-0310-9956-ffa450edef68

Former-commit-id: 368c482
StorDm pushed a commit to etnetera/jmeter that referenced this pull request Jan 7, 2021
@FSchumacher
With varargs there is no need for an extra array
15e4faa 
Part of apache#435 and Bugzilla Id: 62972


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847984 13f79535-47bb-0310-9956-ffa450edef68

Former-commit-id: 4e894b3
StorDm pushed a commit to etnetera/jmeter that referenced this pull request Jan 7, 2021
@FSchumacher
Replace calls to deprecated method Class#newInstance
9d545bc 
Part of apache#435 and Bugzilla Id: 62972


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847985 13f79535-47bb-0310-9956-ffa450edef68

Former-commit-id: 5835c0f
StorDm pushed a commit to etnetera/jmeter that referenced this pull request Jan 7, 2021
@FSchumacher
With varargs there is no need for the arrays
1d8b17b 
Part of apache#435 and Bugzilla Id: 62972


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847986 13f79535-47bb-0310-9956-ffa450edef68

Former-commit-id: dc18430
StorDm pushed a commit to etnetera/jmeter that referenced this pull request Jan 7, 2021
@FSchumacher
Simplify code that tries to find the correct constructor
9da95a6 
Part of apache#435 and Bugzilla Id: 62972


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847987 13f79535-47bb-0310-9956-ffa450edef68

Former-commit-id: dee641b
StorDm pushed a commit to etnetera/jmeter that referenced this pull request Jan 7, 2021
@FSchumacher
Replace calls to deprecated method Class#newInstance
885eb57 
Part of apache#435 and Bugzilla Id: 62972


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847989 13f79535-47bb-0310-9956-ffa450edef68

Former-commit-id: faf53bb
StorDm pushed a commit to etnetera/jmeter that referenced this pull request Jan 7, 2021
@FSchumacher
Adapt test case to new method of constructing instances
7737e90 
Part of apache#435 and Bugzilla Id: 62972


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847990 13f79535-47bb-0310-9956-ffa450edef68

Former-commit-id: 7598524
StorDm pushed a commit to etnetera/jmeter that referenced this pull request Jan 7, 2021
@FSchumacher
Add changelog entry.
b460438 
Closes apache#435
Bugzilla Id: 62972


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1847991 13f79535-47bb-0310-9956-ffa450edef68

Former-commit-id: dcb7579
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@FSchumacher